Feat: Use Besu plugin Gradle plugin #2482
Conversation
fab-10
force-pushed
the
feature/use-gradle-besu-plugin
branch
5 times, most recently
from
136df77 to
c9d848d
Compare
Signed-off-by: Fabio Di Fabio <[email protected]>
fab-10
force-pushed
the
feature/use-gradle-besu-plugin
branch
from
c9d848d to
f741cdc
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| fcp.relativePath = new RelativePath(true, fcp.file.name) | ||
| } | ||
| includeEmptyDirs = false | ||
| duplicatesStrategy = DuplicatesStrategy.FAIL |
There was a problem hiding this comment.
Bug: Duplicate files cause build failure when flattening
The copyTracerPlugin task flattens all files from the distribution zip into a single directory by setting relativePath to just the filename, but uses DuplicatesStrategy.FAIL. If the zip contains files with the same name in different subdirectories, the copy operation will fail instead of handling the duplicates gracefully. This breaks the build when the plugin distribution has a reasonable directory structure with identically-named files in different paths.
There was a problem hiding this comment.
This is intended, since there must be only one dir in the zip
| shomeiVersion=2.4-develop | ||
| besuShomeiPluginVersion=v0.8.2 | ||
| besuArtifactGroup=org.hyperledger.besu | ||
| besuRepo=https://artifacts.consensys.net/public/linea-besu/maven/ |
There was a problem hiding this comment.
Bug: Repository for linea-besu artifacts not configured
The besuRepo property was added to gradle.properties pointing to the linea-besu Maven repository, but this repository is never configured in dependency-management.gradle. The old repository configuration for https://artifacts.consensys.net/public/linea-besu/maven/ was removed, and the new property isn't used anywhere. Since the project uses besuVersion=25.11.0-RC1-linea2 (a linea-specific Besu version), the build will likely fail to resolve linea-besu artifacts that aren't available in the remaining repositories.
Additional Locations (1)
There was a problem hiding this comment.
it is intended, since the new property is used by net.consensys.besu-plugin-library plugin
|
reopened as #2514 |
Note
Migrate build to Besu plugin Gradle plugins, remove legacy scripts/deps, and switch packaging/testing to use
distZip-based plugin distribution.net.consensys.besu-plugin-libraryandnet.consensys.besu-plugin-distributionin root and modules (arithmetization,plugins,reference-tests,testing).settings.gradlefor plugin management.gradle/allprojects.gradle,gradle/common-dependencies.gradle,gradle/dist.gradle) and simplifygradle/dependency-management.gradle.gradle/java.gradleto usejava {}with consistent resolution; enforce Java 21.artifactsto usedistZip.arithmetization: streamline dependencies (keeporg.hyperledger.besu:gnark), add test deps; keep manifest/versioning injar.plugins: use distribution plugin; configurejarmanifest anddistributions { main }; depends on:arithmetization.reference-testsandtesting: apply plugin library; prune Besu-specific deps; keep project/test deps.copyTracerPluginto depend on:plugins:distZipand unzip intobesu.plugins.dir.gradle.properties: addbesuRepo, remove obsolete Besu coordinates; keep release/shomei settings.Written by Cursor Bugbot for commit 17f5738. This will update automatically on new commits. Configure here.